[
https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247610#comment-13247610
]
Uma Maheswara Rao G commented on HBASE-5644:
--------------------------------------------
@Jon, Thanks a lot for review!
{quote}
HTable - row 2, 3
* delete – why is the type bool? Maybre change to ServerCallable<Void>?
(two cases).
{quote}
yes, this would be correct.done.
{quote}
What I wrote above was unclear. You use Preconditions in some places (Store),
and there are places you don't (ShutdownHook). Seems like you could us it in a
few more places? Not a big deal, but it makes code easier to read by conveying
more intent IMO.
Maybe you chose not to use because it wasn't at the top of a method?
{quote}
seems like findbugs not detecting precondition checks in all the places like
inside try, inner-classes.
so, I did not put pre-condions in all the places.
{quote}
You can get this one, it is pretty straightforward. The source of the autogen
RSStatusTmplImpl data is here. Take a look, just modify there and it will just
percolate that code through to the java version.
{quote}
thanks for the reference. updated with this patch.
thanks
Uma
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, HBASE-5644.patch,
> NullPointerFindBugs_Analysis.xlsx
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
