busbey commented on a change in pull request #623: HBASE-22749: Distributed MOB 
compactions
URL: https://github.com/apache/hbase/pull/623#discussion_r327181735
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobConstants.java
 ##########
 @@ -91,12 +81,67 @@
   public static final int DEFAULT_MOB_COMPACTION_CHORE_PERIOD =
     24 * 60 * 60 * 7; // a week
   public static final String MOB_COMPACTOR_CLASS_KEY = 
"hbase.mob.compactor.class";
+
   /**
-   * The max number of threads used in MobCompactor.
+   * Mob compaction type: "full", "generational"
+   * "full" - run full major compaction (during migration)
+   * "generational" - optimized version
    */
-  public static final String MOB_COMPACTION_THREADS_MAX =
 
 Review comment:
   this variable is IA.Public. It would be better to leave the variable in 
place and then issue a WARN on master start up if it is set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to