busbey commented on a change in pull request #623: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/623#discussion_r327185043
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobConstants.java
##########
@@ -91,12 +81,67 @@
public static final int DEFAULT_MOB_COMPACTION_CHORE_PERIOD =
24 * 60 * 60 * 7; // a week
public static final String MOB_COMPACTOR_CLASS_KEY =
"hbase.mob.compactor.class";
+
/**
- * The max number of threads used in MobCompactor.
+ * Mob compaction type: "full", "generational"
+ * "full" - run full major compaction (during migration)
+ * "generational" - optimized version
*/
- public static final String MOB_COMPACTION_THREADS_MAX =
- "hbase.mob.compaction.threads.max";
- public static final int DEFAULT_MOB_COMPACTION_THREADS_MAX = 1;
+ public final static String MOB_COMPACTION_TYPE_KEY =
"hbase.mob.compaction.type";
+
+ public final static String DEFAULT_MOB_COMPACTION_TYPE = "full";
+
+ public final static String GENERATIONAL_MOB_COMPACTION_TYPE = "generational";
+
+ public final static String FULL_MOB_COMPACTION_TYPE = "full";
+
+
+ /**
+ * Maximum size of a MOB compaction selection
+ */
+ public static final String MOB_COMPACTION_MAX_SELECTION_SIZE_KEY =
+ "hbase.mob.compactions.max.selection.size";
+ /**
+ * Default maximum selection size = 1GB
+ */
+ public static final long DEFAULT_MOB_COMPACTION_MAX_SELECTION_SIZE = 1024 *
1024 * 1024;
+
+
+ /**
+ * Minimum number of MOB files eligible for compaction
+ */
+ public static final String MOB_COMPACTION_MIN_FILES_KEY =
"hbase.mob.compactions.min.files";
+
+ public static final int DEFAULT_MOB_COMPACTION_MIN_FILES = 3;
+
+ /**
+ * Maximum number of MOB files (in one selection) eligible for compaction
+ */
+
+ public static final String MOB_COMPACTION_MAX_FILES_KEY =
"hbase.mob.compactions.max.files";
+
+ public static final int DEFAULT_MOB_COMPACTION_MAX_FILES = 100;
+
+ /**
+ * Maximum number of MOB files allowed in MOB compaction (per region)
Review comment:
the comment from the old batch-size above, about limiting the total number
of files due to concerns about max open files, should be included here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
