[
https://issues.apache.org/jira/browse/HBASE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247976#comment-13247976
]
[email protected] commented on HBASE-5719:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4649/#review6713
-----------------------------------------------------------
Nice feature. Can we call it something other than "breakXxx"? Maybe
"-sidelineLargeOverlap"
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14511>
why commented?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14512>
why commented?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14513>
break? maybe a different word?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14514>
instead of nesting, maybe set hfiles to an empty array?
if (hfiles==null) {
hfiles = new FileStatus[0];
}
for (FileStatus hfile : hfiles)
...
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14565>
Instead of "None/Multiple" just say how many htds?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14516>
We lost info here.
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14608>
Pretty important to note that we only "break" groups that exceed the max
number of regions to merge!
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14569>
Comment about what you are trying to accomplish with this method?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14607>
Is this really a failure?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14570>
I think we should bail out in this case.
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14571>
LOG.debug/trace?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14572>
LOG.debug/trace?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14562>
wrong comment for this method
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14563>
Please update usage with new options.
src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
<https://reviews.apache.org/r/4649/#comment14568>
Why this change?
src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
<https://reviews.apache.org/r/4649/#comment14567>
This is a really important function.
Please java doc (maybe an example?) and at least add a unit tests that
cover edge cases here for this.
What is the definition of a "megaOverlap"?
What are the properties of the argument and the return values?
What is the intuition behind how the regions selected are selected and
returned?
- jmhsieh
On 2012-04-04 23:52:50, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4649/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-04 23:52:50)
bq.
bq.
bq. Review request for hbase and jmhsieh.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Make it configurable to sideline some regions in big overlapped groups
which hbck doesn't handle currently.
bq.
bq. The regions chose to sideline are those which overlap with most other
regions.
bq.
bq.
bq. This addresses bug HBASE-5719.
bq. https://issues.apache.org/jira/browse/HBASE-5719
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21
bq. src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
17678dd
bq.
bq. Diff: https://reviews.apache.org/r/4649/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. mvn -PlocalTests -Dtest=TestHBaseFsck* clean test
bq.
bq. Also tested in real system to fix inconsistencies.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Enhance hbck to sideline overlapped mega regions
> ------------------------------------------------
>
> Key: HBASE-5719
> URL: https://issues.apache.org/jira/browse/HBASE-5719
> Project: HBase
> Issue Type: New Feature
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5719.patch
>
>
> If there are too many regions in one overlapped group (by default, more than
> 10), hbck currently doesn't merge them since it takes time.
> In this case, we can sideline some regions in the group and break the
> overlapping to fix the inconsistency. Later on, sidelined regions can be
> bulk loaded manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
