[
https://issues.apache.org/jira/browse/HBASE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250024#comment-13250024
]
[email protected] commented on HBASE-5719:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4649/#review6764
-----------------------------------------------------------
Jimmy,
Looks good to me. Mostly some questions and a little bit of of follow up to
make it easier to read and to provide user more info.
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14916>
nice catch.
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment15130>
Maybe this one is at info level?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14917>
nit: typo (old was correct)
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14918>
Is this <n> per group or globally? please make it clear in usage
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/4649/#comment14919>
nit: should be like previous -maxMerge's comments.
src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
<https://reviews.apache.org/r/4649/#comment15129>
To find? Would returning a sort make sense? if there are no overlaps will
this return the specified number (or less?)
Could this return several regions that now leave holes?
nit: It might make testing clearer to return the overlapCount -> regions
map and check that.
src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
<https://reviews.apache.org/r/4649/#comment15132>
Add comment about structure contents. something like: Integer key is
overlap count and List is regions that have that many overlaps.
maybe rename to overlapRangeMap?
src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
<https://reviews.apache.org/r/4649/#comment15135>
add comment: calculates the # of overlaps for each region and populates
rangeOverlapMap
src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
<https://reviews.apache.org/r/4649/#comment15133>
add comment?
We always overlap with ourselves -- which is why > 1 is the condition
below..
src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
<https://reviews.apache.org/r/4649/#comment15136>
what is the intuition here?
src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
<https://reviews.apache.org/r/4649/#comment15140>
nit: it would easer to read if this was called ai, the next ae, and the one
after that ac.
Also would help if you put the expected overlap count in comments!
- jmhsieh
On 2012-04-06 18:27:34, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4649/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-06 18:27:34)
bq.
bq.
bq. Review request for hbase and jmhsieh.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Make it configurable to sideline some regions in big overlapped groups
which hbck doesn't handle currently.
bq.
bq. The regions chose to sideline are those which overlap with most other
regions.
bq.
bq.
bq. This addresses bug HBASE-5719.
bq. https://issues.apache.org/jira/browse/HBASE-5719
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21
bq. src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java
17678dd
bq.
src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
ac3b225
bq.
bq. Diff: https://reviews.apache.org/r/4649/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. mvn -PlocalTests -Dtest=TestHBaseFsck* clean test
bq.
bq. Also tested in real system to fix inconsistencies.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Enhance hbck to sideline overlapped mega regions
> ------------------------------------------------
>
> Key: HBASE-5719
> URL: https://issues.apache.org/jira/browse/HBASE-5719
> Project: HBase
> Issue Type: New Feature
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5719.patch
>
>
> If there are too many regions in one overlapped group (by default, more than
> 10), hbck currently doesn't merge them since it takes time.
> In this case, we can sideline some regions in the group and break the
> overlapping to fix the inconsistency. Later on, sidelined regions can be
> bulk loaded manually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
