joshelser commented on a change in pull request #712: HBASE-23136
URL: https://github.com/apache/hbase/pull/712#discussion_r334093821
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoadReplication.java
##########
@@ -232,6 +253,23 @@ public void testBulkLoadReplicationActiveActive() throws
Exception {
assertEquals(9, BULK_LOADS_COUNT.get());
}
+ @Test
+ public void testPartionedMOBCompactionBulkLoadDoesntReplicate() throws
Exception {
+ Path path = createMobFiles(UTIL3);
+ ColumnFamilyDescriptor descriptor =
+ new
ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(famName);
+ PartitionedMobCompactor compactor = new
PartitionedMobCompactor(UTIL3.getConfiguration(),
+ UTIL3.getTestFileSystem(), tableName, descriptor,
Executors.newFixedThreadPool(1));
Review comment:
Close the ThreadPool? I forget how we manage surefire forks, if this would
orphan a thread for some reasonable length of time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
