joshelser commented on a change in pull request #712: HBASE-23136
URL: https://github.com/apache/hbase/pull/712#discussion_r334093708
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFiles.java
 ##########
 @@ -84,6 +84,10 @@ public Path getFilePath() {
   Map<LoadQueueItem, ByteBuffer> bulkLoad(TableName tableName, Map<byte[], 
List<Path>> family2Files)
       throws TableNotFoundException, IOException;
 
+  /**
+   * Disable replication for this bulkload, if bulkload replication is 
configured.
 
 Review comment:
   What about: `Disables replication for all bulkloads done via this instance, 
when bulkload replication is configured.`
   
   "this bulkload" could be interpreted as something the user has to call 
before each call to `bulkLoad(..)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to