bharathv commented on a change in pull request #808: HBASE-20395 Displaying 
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344277816
 
 

 ##########
 File path: 
hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
 ##########
 @@ -192,6 +192,14 @@ exception AlreadyExists {
   1:string message
 }
 
+/**
+ * Specify type of thrift server: thrift and thrift2
+ */
+enum TThriftServerType {
 
 Review comment:
   rather than defining the same enum twice in both the thrift files, is it 
better to have a const defined? 
   
   const i16 THRIFT_SERVER_TYPE = 1; // in thrift1
   const i16 THRIFT_SERVER_TYPE =2 // in thrift2
   
   Each thrift server impl can use it's corresponding type directly. Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to