bharathv commented on a change in pull request #808: HBASE-20395 Displaying 
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344272299
 
 

 ##########
 File path: 
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
 ##########
 @@ -61,11 +61,11 @@ public void setSource(MetricsThriftServerSource source) {
   public static final String SLOW_RESPONSE_NANO_SEC =
     "hbase.thrift.slow.response.nano.second";
   public static final long DEFAULT_SLOW_RESPONSE_NANO_SEC = 10 * 1000 * 1000;
-
+  public final String thriftServerType;
 
   public ThriftMetrics(Configuration conf, ThriftServerType t) {
 
 Review comment:
   Get rid of the num ThriftServerType here and use the one from HBase.thrift?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to