bharathv commented on a change in pull request #808: HBASE-20395 Displaying thrift server type on the thrift page URL: https://github.com/apache/hbase/pull/808#discussion_r344268598
########## File path: hbase-examples/src/main/python/thrift1/DemoClient.py ########## @@ -66,6 +66,11 @@ def demo_client(host, port, is_framed_transport): # Connect! transport.open() + # Check Thrift Server Type + serverType = client.getThriftServerType() + if serverType != 1: Review comment: Use the version from the thrift file instead of '1'? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
