virajjasani commented on a change in pull request #809: HBASE-23261 : 
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344848824
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java
 ##########
 @@ -163,6 +166,10 @@ public void waitForSplitTransaction(final 
RegionServerServices services, Region
         }
         Thread.sleep(100);
         spins++;
+        if (spins > SPLIT_WAIT_TIMEOUT) {
 
 Review comment:
   @apurtell we retry here for ~20-24s. We try to update ZNode to 
RS_ZK_REQUEST_REGION_SPLIT 
[here](https://github.com/apache/hbase/pull/809/files#diff-fdc12d2818ed13d9c47380d943712d9fR164)
 (L:164) to request master for split. If it fails due to BVE, well we again 
come back there and re-do the same thing until we succeed(all this code inside 
while loop). The success is measured by RS getting positive response from 
master in the form of ZNode state being updated to RS_ZK_REGION_SPLITTING 
[here](https://github.com/apache/hbase/pull/809/files#diff-fdc12d2818ed13d9c47380d943712d9fR179)(L:179)
 from where RS exits from this while loop successfully, if not successful for 
~20-24s, on this line(L:169) we are introducing exit condition with IOE, which 
will be responsible to rollback splitting after catching this IOE 
[here](https://github.com/apache/hbase/blob/f7ca22fd4890a952fcf8fa66254fe08567bf2306/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java#L85)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to