virajjasani commented on a change in pull request #809: HBASE-23261 : 
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344857395
 
 

 ##########
 File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
 ##########
 @@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw, 
HRegionInfo region,
     try {
       rt = RegionTransition.createRegionTransition(
           endState, region.getRegionName(), serverName, payload);
-      if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+      boolean isDataSet;
+      try {
+        isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(), 
stat.getVersion());
 
 Review comment:
   We tend to re-read updated value with retry mechanism as per the comment 
[here](https://github.com/apache/hbase/pull/809/files#r344848824)
   It is already in a while loop, we are just restricting it to no of retries

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to