virajjasani commented on a change in pull request #809: HBASE-23261 :
Processing ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344877845
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java
##########
@@ -163,6 +166,10 @@ public void waitForSplitTransaction(final
RegionServerServices services, Region
}
Thread.sleep(100);
spins++;
+ if (spins > SPLIT_WAIT_TIMEOUT) {
Review comment:
Here, we are already in a while loop, and the only way to come out of it
with successful splitting is to get `RS_ZK_REGION_SPLITTING` from ZNode which
should have been done by master, which would have happened only if RS had
successfully transitioned ZNode to `RS_ZK_REQUEST_REGION_SPLIT`, which would
happen only if BVE is not encountered. Until then, we are anyways in this while
loop
`while (!(coordinationManager.getServer().isStopped() ||
services.isStopping())) {` and retrying `transitionSplittingNode()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services