[ 
https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977882#comment-16977882
 ] 

Michael Stack commented on HBASE-23279:
---------------------------------------

On patch, this 

        n -> DataBlockEncoding.valueOf(n.toUpperCase()), 
DataBlockEncoding.ROW_INDEX_V1);

should be...

        n -> DataBlockEncoding.valueOf(n.toUpperCase()), DataBlockEncoding. 
DEFAULT_DATA_BLOCK_ENCODING); ?

Same here...

      return setValue(DATA_BLOCK_ENCODING_BYTES, type == null ?
812             DataBlockEncoding.ROW_INDEX_V1.name() : type.name());

Same here...

private DataBlockEncoding encoding = DataBlockEncoding.ROW_INDEX_V1;

... and so on .



> Switch default block encoding to ROW_INDEX_V1
> ---------------------------------------------
>
>                 Key: HBASE-23279
>                 URL: https://issues.apache.org/jira/browse/HBASE-23279
>             Project: HBase
>          Issue Type: Wish
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Lars Hofhansl
>            Assignee: Viraj Jasani
>            Priority: Minor
>             Fix For: 3.0.0, 2.3.0
>
>         Attachments: HBASE-23279.master.000.patch, 
> HBASE-23279.master.001.patch
>
>
> Currently we set both block encoding and compression to NONE.
> ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles 
> are slightly larger about 3% or so). I think that would a better default than 
> NONE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to