[
https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980983#comment-16980983
]
Lars Hofhansl commented on HBASE-23279:
---------------------------------------
Patch looks good generally. Are the changes for the tests necessary (keeping
NONE as encoding) required to have them pass? That would be a bit scary.
Also the size difference is unexpectedly high... I guess it depends on the size
of the keys relative to the total size of the Cells, in my tests I've seen
about 3%. I tested with Phoenix:
{{CREATE TABLE <table> (pk INTEGER PRIMARY key, v1 FLOAT, v2 FLOAT, v3
INTEGER)}}
So there would 3 cells per "row" with 4 bytes as the row key, each with a 4
byte value. I'd expect that to be pretty bad case for row indexing. Are those
heap sizes, file sizes, or bucket cache sizes?
> Switch default block encoding to ROW_INDEX_V1
> ---------------------------------------------
>
> Key: HBASE-23279
> URL: https://issues.apache.org/jira/browse/HBASE-23279
> Project: HBase
> Issue Type: Wish
> Affects Versions: 3.0.0, 2.3.0
> Reporter: Lars Hofhansl
> Assignee: Viraj Jasani
> Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-23279.master.000.patch,
> HBASE-23279.master.001.patch, HBASE-23279.master.002.patch,
> HBASE-23279.master.003.patch
>
>
> Currently we set both block encoding and compression to NONE.
> ROW_INDEX_V1 has many advantages and (almost) no disadvantages (the hfiles
> are slightly larger about 3% or so). I think that would a better default than
> NONE.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
