busbey commented on a change in pull request #916: HBASE-23382: Clean up
Logging for Some of hbase-server Module
URL: https://github.com/apache/hbase/pull/916#discussion_r356400203
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ZNodeClearer.java
##########
@@ -194,10 +194,10 @@ public static boolean clear(Configuration conf) {
}
} catch (FileNotFoundException fnfe) {
// If no file, just keep going -- return success.
- LOG.warn("Can't find the znode file; presume non-fatal", fnfe);
+ LOG.warn("Failed to find the znode file; presume non-fatal", fnfe);
Review comment:
should this be at WARN given that we presume it's non-fatal? maybe info with
an updated message that makes it clearer we treat this the same as if the
server cleaned up after itself?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
