busbey commented on a change in pull request #916: HBASE-23382: Clean up
Logging for Some of hbase-server Module
URL: https://github.com/apache/hbase/pull/916#discussion_r356408716
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
##########
@@ -183,13 +178,8 @@ public void write(ByteBuffer srcBuffer, long offset)
throws IOException {
@Override
public void sync() throws IOException {
for (int i = 0; i < fileChannels.length; i++) {
- try {
- if (fileChannels[i] != null) {
- fileChannels[i].force(true);
- }
- } catch (IOException ie) {
- LOG.warn("Failed syncing data to " + this.filePaths[i]);
- throw ie;
+ if (fileChannels[i] != null) {
+ fileChannels[i].force(true);
Review comment:
where `sync` gets called we log this IOE if it happens? that message
includes the specific path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
