busbey commented on a change in pull request #916: HBASE-23382: Clean up
Logging for Some of hbase-server Module
URL: https://github.com/apache/hbase/pull/916#discussion_r356407410
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java
##########
@@ -545,7 +545,7 @@ public void setTo(long free, long used, long itemSize) {
void logStatistics() {
IndexStatistics total = new IndexStatistics();
IndexStatistics[] stats = getIndexStatistics(total);
- LOG.info("Bucket allocator statistics follow:\n");
+ LOG.info("Bucket allocator statistics follow:");
Review comment:
I think we should remove this preamble and make each of the below logs just
start with something like `"Bucket allocator stats: "`.
unless we add a log message after the for loop that basically says "we
finished logging the bucket allocator statistics" it's not like we can use this
preamble log line to better find sets of these logs in the noise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
