bharathv commented on a change in pull request #995: HBASE-23055 Alter 
hbase:meta
URL: https://github.com/apache/hbase/pull/995#discussion_r363618881
 
 

 ##########
 File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterKeepAliveConnection.java
 ##########
 @@ -35,7 +38,8 @@
  * final user code. Hence it's package protected.
  */
 @InterfaceAudience.Private
-interface MasterKeepAliveConnection extends 
MasterProtos.MasterService.BlockingInterface {
+interface MasterKeepAliveConnection extends
+    MasterProtos.MasterService.BlockingInterface, Closeable {
   // Do this instead of implement Closeable because closeable returning IOE is 
PITA.
 
 Review comment:
   nit: update the comment? Thats contradicting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to