saintstack commented on a change in pull request #995: HBASE-23055 Alter
hbase:meta
URL: https://github.com/apache/hbase/pull/995#discussion_r363944460
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegistry.java
##########
@@ -29,12 +30,26 @@
*/
@InterfaceAudience.Private
interface AsyncRegistry extends Closeable {
+ /**
+ * A completed CompletableFuture to host default hbase:meta table state
(ENABLED).
+ */
+ TableState ENABLED_META_TABLE_STATE =
+ new TableState(TableName.META_TABLE_NAME, TableState.State.ENABLED);
+ CompletableFuture<TableState> COMPLETED_GET_META_TABLE_STATE =
+ CompletableFuture.completedFuture(ENABLED_META_TABLE_STATE);
/**
* Get the location of meta region.
*/
CompletableFuture<RegionLocations> getMetaRegionLocation();
+ /**
+ * The hbase:meta table state.
+ */
+ default CompletableFuture<TableState> getMetaTableState() {
Review comment:
No. The opposite I'd say. Up to this, meta table state was hard-wired
ENABLED -- i.e. the default here. There are two Registry implementations
currently. The ZK-based one and the one you are working on. The ZKRegistry got
an impl as part of this patch. Will work on one for when your Registry lands.
Meantime, default impl.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
