bharathv commented on a change in pull request #995: HBASE-23055 Alter
hbase:meta
URL: https://github.com/apache/hbase/pull/995#discussion_r363614389
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -330,6 +342,26 @@ public void newDead(ServerName sn) {
close();
throw e;
}
+ // Create tablestate cache. Add a loader that know how to find table state.
+ int duration = this.conf.getInt(TABLESTATE_CACHE_DURATION_MS, 1000);
+ this.tableStateCache = CacheBuilder.newBuilder().
+ expireAfterWrite(duration, TimeUnit.MILLISECONDS).
+ recordStats().
Review comment:
nit: The patch doesn't use the recorded states anywhere. Unnecessary
overhead, can be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
