saintstack commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r369162290
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileReaderImpl.java
##########
@@ -66,9 +65,8 @@ Path makeNewFile() throws IOException {
HFileContext context =
new
HFileContextBuilder().withBlockSize(blocksize).withIncludesTags(true).build();
Configuration conf = TEST_UTIL.getConfiguration();
- HFile.Writer writer =
-
HFile.getWriterFactoryNoCache(conf).withOutputStream(fout).withFileContext(context)
- .withComparator(CellComparatorImpl.COMPARATOR).create();
+ HFile.Writer writer = HFile.getWriterFactoryNoCache(conf).
+ withOutputStream(fout).withFileContext(context).create();
Review comment:
I went through the patch and I made all align w/ your suggestions. Thanks
@HorizonNet .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
