anoopsjohn commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368653450
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java
##########
@@ -154,19 +153,6 @@ private int binarySearch(Cell seekCell, boolean
seekBefore) {
}
}
- private int compareRows(ByteBuffer row, Cell seekCell) {
Review comment:
I understood ur arg now. Make sense... The MetaCellComparator was doing on
heap copy. So ur impl there is ok as of now. May be we can see whether we can
avoid some of those. But can be another jira. +1 for doing this way boss.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
