saintstack commented on a change in pull request #1062: HBASE-23705 Add 
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368657173
 
 

 ##########
 File path: 
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java
 ##########
 @@ -154,19 +153,6 @@ private int binarySearch(Cell seekCell, boolean 
seekBefore) {
     }
   }
 
-  private int compareRows(ByteBuffer row, Cell seekCell) {
 
 Review comment:
   Thanks @anoopsjohn 
   
   Will put up new patch that implements your suggestions and those of 
@HorizonNet 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to