saintstack commented on a change in pull request #1039: HBASE-23647: Make
MasterRegistry the default impl.
URL: https://github.com/apache/hbase/pull/1039#discussion_r369935638
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
##########
@@ -170,27 +171,36 @@ public LocalHBaseCluster(final Configuration conf, final
int noMasters,
this.masterClass = (Class<? extends HMaster>)
conf.getClass(HConstants.MASTER_IMPL, masterClass);
// Start the HMasters.
- for (int i = 0; i < noMasters; i++) {
+ int i;
+ for (i = 0; i < noMasters; i++) {
addMaster(new Configuration(conf), i);
}
-
- // Populate the master address host ports in the config. This is needed if
a master based
- // registry is configured for client metadata services (HBASE-18095)
- List<String> masterHostPorts = new ArrayList<>();
- getMasters().forEach(masterThread ->
-
masterHostPorts.add(masterThread.getMaster().getServerName().getAddress().toString()));
- conf.set(HConstants.MASTER_ADDRS_KEY, String.join(",", masterHostPorts));
-
+ for (int j = 0; j < noAlwaysStandByMasters; j++) {
+ Configuration c = new Configuration(conf);
+ c.set(HConstants.MASTER_IMPL,
"org.apache.hadoop.hbase.master.AlwaysStandByHMaster");
Review comment:
Late to the game , but what is an AlwaysStandByHMaster rather than
StandByMaster? Why the Always? Maybe it will make sense later in review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
