saintstack commented on a change in pull request #1039: HBASE-23647: Make
MasterRegistry the default impl.
URL: https://github.com/apache/hbase/pull/1039#discussion_r369945441
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java
##########
@@ -96,7 +96,7 @@ public void
testRSTerminationAfterRegisteringToMasterBeforeCreatingEphemeralNode
TEST_UTIL.startMiniZKCluster();
TEST_UTIL.createRootDir();
final LocalHBaseCluster cluster =
- new LocalHBaseCluster(conf, NUM_MASTERS, NUM_RS, HMaster.class,
+ new LocalHBaseCluster(conf, NUM_MASTERS, 0, NUM_RS, HMaster.class,
Review comment:
We seem to do '0' as AlwaysMasters. Should we do override that defaults
zero? Just to keep the AlwaysMasters out of view when not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
