saintstack commented on a change in pull request #1039: HBASE-23647: Make 
MasterRegistry the default impl.
URL: https://github.com/apache/hbase/pull/1039#discussion_r369943132
 
 

 ##########
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/StartMiniClusterOption.java
 ##########
 @@ -46,6 +46,14 @@
    * can find the active/primary master with {@link 
MiniHBaseCluster#getMaster()}.
    */
   private final int numMasters;
+
+  /**
+   * Number of masters that always remain standby. These set of masters never 
transition to active
+   * even if an active master does not exist. These are needed for testing 
scenarios where there are
+   * no active masters in the cluster but the cluster connection (backed by 
master registry) should
+   * still work.
+   */
+  private final int numAlwaysStandByMasters;
 
 Review comment:
   Oh, so a hack to get around some test scenarios. Ok. Good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to