ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r371431530
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##########
@@ -215,6 +224,17 @@
*/
private RSRpcServices rsRpcServices;
+
+ /**
+ * Use to add online slowlog responses
+ */
+ private OnlineSlowLogProvider onlineSlowLogProvider;
+
+ private final boolean isOnlineSlowLogProviderEnabled;
+
+ static final String ENABLED_ONLINE_LOG_PROVIDER =
"hbase.regionserver.slowlog.enabled";
Review comment:
In the current implementation, we emit a log message regardless of whether
this configuration is true or false. If that is to remain the case, a better
name is `SLOW_LOG_BUFFER_ENABLED_KEY`,
`hbase.regionserver.slowlog.buffer.enabled `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
