ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r371433786
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##########
@@ -440,25 +463,28 @@ public void setSecretManager(SecretManager<? extends
TokenIdentifier> secretMana
* @param param The parameters received in the call.
* @param methodName The name of the method invoked
* @param call The string representation of the call
- * @param tag The tag that will be used to indicate this event in the log.
+ * @param tooLarge To indicate if the event is tooLarge or tooSlow
Review comment:
An event that has `tooLarge=false` does not imply to me that `tooSlow=true`.
These are independent concepts that should not be mashed into a single
parameter. The previous parameter "tag" was simply a log annotation, not a
decision criteria. Here you've replaced it with a decision condition that lacks
expression. If you want to pursue this change, please include parameters for
both boolean flags, or implement something like a bit-mask that allows for
multiple states to be expressed simultaneously.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
