ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r371436317
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##########
@@ -496,11 +522,44 @@ void logResponse(Message param, String methodName,
String call, String tag,
}
}
}
- responseInfo.put("multi.gets", numGets);
- responseInfo.put("multi.mutations", numMutations);
- responseInfo.put("multi.servicecalls", numServiceCalls);
+ responseInfo.put(MULTI_GETS, numGets);
+ responseInfo.put(MULTI_MUTATIONS, numMutations);
+ responseInfo.put(MULTI_SERVICECALLS, numServiceCalls);
}
+ final String tag = tooLarge ? "TooLarge" : "TooSlow";
LOG.warn("(response" + tag + "): " + GSON.toJson(responseInfo));
+ if (isOnlineSlowLogProviderEnabled && !tooLarge &&
this.onlineSlowLogProvider != null
+ && !call.startsWith("GetSlowLogResponses")
+ && !call.startsWith("ClearSlowLogsResponses")) {
+ // add too slow log to ringbuffer for retrieval of latest n slow logs
+
+ try {
+ final SlowLogParams slowLogParams =
ProtobufUtil.getSlowLogParams(param);
+
+ final SlowLogPayload slowLogPayload = SlowLogPayload.newBuilder()
+ .setStartTime(startTime)
+ .setProcessingTime(processingTime)
+ .setQueueTime(qTime)
+ .setResponseSize(responseSize)
+ .setClientAddress(clientAddress)
+ .setServerClass(className)
+ .setMethodName(methodName)
+ .setCallDetails(call)
+ .setUserName(userName)
+ .setRegionName(slowLogParams != null ? slowLogParams.getRegionName()
: StringUtils.EMPTY)
+ .setParam(slowLogParams != null ? slowLogParams.getParams() :
StringUtils.EMPTY)
+ .setMultiGets(responseInfo.containsKey(MULTI_GETS)
+ ? (int) responseInfo.get(MULTI_GETS) : 0)
+ .setMultiMutations(responseInfo.containsKey(MULTI_MUTATIONS)
+ ? (int) responseInfo.get(MULTI_MUTATIONS) : 0)
+ .setMultiServiceCalls(responseInfo.containsKey(MULTI_SERVICECALLS)
+ ? (int) responseInfo.get(MULTI_SERVICECALLS) : 0)
+ .build();
+ this.onlineSlowLogProvider.addSlowLogPayload(slowLogPayload);
+ } catch (Exception e) {
+ LOG.error("Error while adding slowlog response to ringbuffer..", e);
Review comment:
nit: extra period in log message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
