[
https://issues.apache.org/jira/browse/HBASE-23779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031911#comment-17031911
]
Michael Stack commented on HBASE-23779:
---------------------------------------
I pushed this last night into master branch as addendum in hbase-personality.
It don't seem to work either:
{code}
commit 867b1e9cbca6217da84d12b8a1772af8e607bd36 (HEAD -> m, origin/master,
origin/HEAD)
Author: stack <[email protected]>
Date: Wed Feb 5 21:47:34 2020 -0800
HBASE-23779 Up the default fork count; make count relative to CPU count
(#1108)
ADDENDUM: Try this way of setting MAVEN_ARGS
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 76fc96bf76..169f19abcc 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -81,13 +81,14 @@ function personality_globals
# Override the maven options
MAVEN_OPTS="${MAVEN_OPTS:-"-Xms4G -Xmx4G"}"
+
# Pass maven a -T argument. Should make it run faster. Pass conservative
value.
# Default is one thread. 0.5C on an apache box of 24 cores and 2 executors
should
# make for 6 threads? Lets see. Setting this here for yetus to pick up. See
#
https://yetus.apache.org/documentation/0.11.1/precommit-advanced/#global-definitions
# See below for more on -T:
#
https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3
- export MAVEN_ARGS="-T0.5C ${MAVEN_ARGS}"
+ MAVEN_ARGS=("-T0.5C" "${MAVEN_ARGS[@]}")
{code}
> Up the default fork count to make builds complete faster; make count relative
> to CPU count
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-23779
> URL: https://issues.apache.org/jira/browse/HBASE-23779
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Michael Stack
> Assignee: Michael Stack
> Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: test_yetus_934.0.patch
>
>
> Tests take a long time. Our fork count running all tests are conservative --
> 1 (small) for first part and 5 for second part (medium and large). Rather
> than hardcoding we should set the fork count to be relative to machine size.
> Suggestion here is 0.75C where C is CPU count. This ups the CPU use on my box.
> Looking up at jenkins, it seems like the boxes are 24 cores... at least going
> by my random survey. The load reported on a few seems low though this not
> representative (looking at machine/uptime).
> More parallelism willl probably mean more test failure. Let me take a look
> see.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
