bharathv commented on a change in pull request #934: HBASE-23568: Improve
Threading of Replication
URL: https://github.com/apache/hbase/pull/934#discussion_r376665954
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -690,13 +705,8 @@ public ReplicationQueueInfo getReplicationQueueInfo() {
return replicationQueueInfo;
}
- public boolean isWorkerRunning(){
- for(ReplicationSourceShipper worker : this.workerThreads.values()){
- if(worker.isActive()){
- return worker.isActive();
- }
- }
- return false;
+ public boolean isWorkerRunning() {
+ return !this.workerThreads.isEmpty();
Review comment:
isn't this a change of semantics? (there could be window where it isn't
active but still in the map..). Doesn't probably matter that much but just
wondering..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
