bharathv commented on a change in pull request #934: HBASE-23568: Improve
Threading of Replication
URL: https://github.com/apache/hbase/pull/934#discussion_r373907272
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RecoveredReplicationSourceShipper.java
##########
@@ -92,10 +86,7 @@ private void terminate(String reason, Exception cause) {
"Closing worker for wal group " + this.walGroupId + " because an error
occurred: " + reason,
cause);
}
- entryReader.interrupt();
- Threads.shutdown(entryReader, sleepForRetries);
- this.interrupt();
- Threads.shutdown(this, sleepForRetries);
- LOG.info("ReplicationSourceWorker {} terminated", this.getName());
+ LOG.info("ReplicationSourceWorker stopping");
Review comment:
nit: move into stopWorker()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
