bharathv commented on a change in pull request #934: HBASE-23568: Improve
Threading of Replication
URL: https://github.com/apache/hbase/pull/934#discussion_r376661463
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -126,10 +134,16 @@
private long defaultBandwidth;
private long currentBandwidth;
private WALFileLengthProvider walFileLengthProvider;
+
@VisibleForTesting
- protected final ConcurrentHashMap<String, ReplicationSourceShipper>
workerThreads =
+ protected final Map<String, ReplicationSourceShipper> workerThreads =
new ConcurrentHashMap<>();
+ private final ListeningExecutorService executorService =
Review comment:
This could use some comments (what is in this executor service?).. While you
are here, mind adding some javadocs for the workerThreads too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
