[ 
https://issues.apache.org/jira/browse/HBASE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254932#comment-13254932
 ] 

Jean-Daniel Cryans commented on HBASE-5782:
-------------------------------------------

bq. In order to get 0.94.0 out the door, can we pull back HBASE-4487 in 0.94 
and pursue the locking approach in trunk (or separate branch) ?

+1, we might want to review HBASE-4282 too as it seems to do something similar 
with the transaction ids.

bq. So the problem is that logSyncerThread keeps the edit in order but the 
syncer then applies the pending batches potentially out of order?

It's sad that the pending edits live in {{LogSyncer}}, that thread is really 
just suppose to call sync... but yeah so they are added there in order but then 
it's a free for all in {{syncer}}. Adding a sync there could solve the issue 
but in the end what it does is moving the log from appending (pre HBASE-4487) 
to syncing plus a _ton_ of new complexity in HLog. I'd prefer solution that 
doesn't add a lock to patch something that's broken.
                
> Not all the regions are getting assigned after the log splitting.
> -----------------------------------------------------------------
>
>                 Key: HBASE-5782
>                 URL: https://issues.apache.org/jira/browse/HBASE-5782
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.94.0
>            Reporter: Gopinathan A
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5782.patch
>
>
> Create a table with 1000 splits, after the region assignemnt, kill the 
> regionserver wich contains META table.
> Here few regions are missing after the log splitting and region assigment. 
> HBCK report shows multiple region holes are got created.
> Same scenario was verified mulitple times in 0.92.1, no issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to