Apache9 commented on a change in pull request #1260: HBASE-23881 Ensure Netty
client receives at least one response before…
URL: https://github.com/apache/hbase/pull/1260#discussion_r390040132
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
##########
@@ -114,7 +122,10 @@ public void handlerAdded(ChannelHandlerContext ctx) {
if (initialResponse != null) {
writeResponse(ctx, initialResponse);
}
- tryComplete(ctx);
+ // HBASE-23881 We do not want to check if the SaslClient thinks the
handshake is
Review comment:
Is this correct?
The comment is
```
* Determines whether the authentication exchange has completed.
* This method may be called at any time, but typically, it
* will not be called until the caller has received indication
* from the server
* (in a protocol-specific manner) that the exchange has completed.
```
It does not say that we 'must' call it after we receive the reponse from
server.
And I'm curious that, what is the sasl client implementation? It just marks
itself as complete succeeded, without any server response, and then after the
server response it could revert itself as auth failed? I think this is a broken
sasl client implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
