joshelser commented on issue #1260: HBASE-23881 Ensure Netty client receives at least one response before… URL: https://github.com/apache/hbase/pull/1260#issuecomment-597279053 > Once we have sent out a SaslToken, then we need to get one back. We could just make some AtomicBoolean, defaulting to false, which is changed to true after the first call to `channelRead0` and then check that value in `tryComplete`, but I can't help but thinking it's less state to manage to just be clear that we need at least one response back from the server. Do you think it's better to have an explicit check in the code rather than comments saying "don't re-add this"? > Where EMPTY_TOKEN is a byte[0], but in upper layer. we will check null to determine whether we have an initial response... Will push a fix for this. Nice catch. I didn't notice that.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
