Apache9 commented on issue #1260: HBASE-23881 Ensure Netty client receives at least one response before… URL: https://github.com/apache/hbase/pull/1260#issuecomment-596867525 Think again, the end condition here should be: 1. SaslClient.isComplete returns true 2. Once we have sent out a SaslToken, then we need to get one back. Let me check the code again. Found a bug through a roughly looking... ``` public byte[] getInitialResponse() throws SaslException { if (saslClient.hasInitialResponse()) { return saslClient.evaluateChallenge(EMPTY_TOKEN); } else { return EMPTY_TOKEN; } } ``` Where EMPTY_TOKEN is a byte[0], but in upper layer. we will check null to determine whether we have an initial response...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
