virajjasani commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r401438493
##########
File path: hbase-protocol-shaded/src/main/protobuf/Admin.proto
##########
@@ -369,6 +369,9 @@ service AdminService {
rpc GetSlowLogResponses(SlowLogResponseRequest)
returns(SlowLogResponses);
+ rpc GetLargeLogResponses(SlowLogResponseRequest)
Review comment:
We discussed about getting rid of separate Admin API and have a same
endpoint. This one is for RS RPC services. Since we don't want to have multiple
enums in Admin.proto, TooSlowLogs.proto, we need this separately and it's only
used in RSRpcServices with minimal code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
