virajjasani commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r401503131
##########
File path: hbase-protocol-shaded/src/main/protobuf/Admin.proto
##########
@@ -369,6 +369,9 @@ service AdminService {
rpc GetSlowLogResponses(SlowLogResponseRequest)
returns(SlowLogResponses);
+ rpc GetLargeLogResponses(SlowLogResponseRequest)
Review comment:
Another reason why we must have this is to find out sometimes which specific
Get API was slow or large in nature even between get_slow and get_large
responses.
Sample response:
```
{
"startTime": 1585735414657,
"processingTime": 1,
"queueTime": 0,
"responseSize": 2351,
"clientAddress": "171.30.20.8:63571",
"serverClass": "HRegionServer",
"methodName": "GetLargeLogResponses",
"callDetails":
"GetLargeLogResponses(org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$SlowLogResponseRequest)",
"param": "class
org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$SlowLogResponseRequest",
"userName": "vjasani"
}
{
"startTime": 1585735372313,
"processingTime": 1,
"queueTime": 0,
"responseSize": 2260,
"clientAddress": "171.30.20.8:63571",
"serverClass": "HRegionServer",
"methodName": "GetSlowLogResponses",
"callDetails":
"GetSlowLogResponses(org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$SlowLogResponseRequest)",
"param": "class
org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$SlowLogResponseRequest",
"userName": "vjasani"
}
```
For this differentiation, we need to have: `rpc
GetLargeLogResponses(SlowLogResponseRequest)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
