bharathv commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r401215748
##########
File path: hbase-protocol-shaded/src/main/protobuf/TooSlowLog.proto
##########
@@ -42,4 +42,12 @@ message SlowLogPayload {
optional int32 multi_gets = 12 [default = 0];
optional int32 multi_mutations = 13 [default = 0];
optional int32 multi_service_calls = 14 [default = 0];
+ required Type type = 15;
+
+ enum Type {
+ SLOW_LOG = 0;
+ LARGE_LOG = 1;
Review comment:
nit: Helps to have a code comment about what a SLOW log is and what a LARGE
log is..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
