ndimiduk commented on a change in pull request #1440: HBASE-23113: Improve and
add additional Netty configuration for RPC.
URL: https://github.com/apache/hbase/pull/1440#discussion_r404397333
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
##########
@@ -258,6 +252,8 @@ private void connect() {
.option(ChannelOption.SO_KEEPALIVE, rpcClient.tcpKeepAlive)
.option(ChannelOption.CONNECT_TIMEOUT_MILLIS, rpcClient.connectTO)
.handler(new
BufferCallBeforeInitHandler()).localAddress(rpcClient.localAddr)
+ .option(ChannelOption.WRITE_BUFFER_WATER_MARK,
+ ((NettyRpcClient) rpcClient).writeBufferWaterMark)
Review comment:
This cast is redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
