ndimiduk commented on a change in pull request #1440: HBASE-23113: Improve and
add additional Netty configuration for RPC.
URL: https://github.com/apache/hbase/pull/1440#discussion_r404396322
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java
##########
@@ -45,24 +46,45 @@
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
public class NettyRpcClient extends AbstractRpcClient<NettyRpcConnection> {
+ protected final WriteBufferWaterMark writeBufferWaterMark;
+
+ protected static final String CLIENT_CONNECT_MAX_RETRIES =
"hbase.ipc.client.connect.max.retries";
Review comment:
These first three are unused. Any anyway, the parent class manages reading
these values from configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
