markrmiller commented on a change in pull request #1440: HBASE-23113: Improve
and add additional Netty configuration for RPC.
URL: https://github.com/apache/hbase/pull/1440#discussion_r404979877
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java
##########
@@ -67,20 +68,49 @@
* Tests may set this down from unlimited.
*/
public static final String HBASE_NETTY_EVENTLOOP_RPCSERVER_THREADCOUNT_KEY =
- "hbase.netty.eventloop.rpcserver.thread.count";
+ "hbase.netty.eventloop.rpcserver.thread.count";
private static final int EVENTLOOP_THREADCOUNT_DEFAULT = 0;
+ protected static final String SERVER_TCP_BACKLOG =
"hbase.ipc.server.tcpbacklog";
+ protected static final String SERVER_TCP_REUSEADDR =
"hbase.ipc.server.tcpreuseaddr";
+ protected static final String SERVER_TCP_NODELAY =
"hbase.ipc.server.tcpnodelay";
+ protected static final String SERVER_TCP_KEEPALIVE =
"hbase.ipc.server.tcpkeepalive";
+
+ protected static final String SERVER_BUFFER_LOW_WATERMARK =
"hbase.ipc.server.bufferlowwatermark";
+ protected static final String SERVER_BUFFER_HIGH_WATERMARK =
+ "hbase.ipc.server.bufferhighwatermark";
+
+ protected static final boolean DEFAULT_SERVER_REUSEADDR = true;
+ protected static final int DEFAULT_SERVER_TCP_BACKLOG = 1024;
Review comment:
For the WATER_MARK settings, the previous pr is using:
protected static final int DEFAULT_SERVER_BUFFER_LOW_WATERMARK = 1024;
protected static final int DEFAULT_SERVER_BUFFER_HIGH_WATERMARK = 64 * 1024;
If the number of queued bytes goes above the high mark, then
channel.isWritable will return false until the number of outstanding bytes
falls below the low water mark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
