busbey commented on a change in pull request #1446: HBASE-23723 Ensure MOB 
compaction works in optimized mode after snapshot clone
URL: https://github.com/apache/hbase/pull/1446#discussion_r405713614
 
 

 ##########
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java
 ##########
 @@ -152,49 +167,102 @@ private void loadData(int num) {
   public void tearDown() throws Exception {
     admin.disableTable(tableDescriptor.getTableName());
     admin.deleteTable(tableDescriptor.getTableName());
-    HTU.shutdownMiniCluster();
   }
 
-
+  @Test
   public void baseTestMobFileCompaction() throws InterruptedException, 
IOException {
+    LOG.info("MOB compaction " + description() + " started");
+    loadAndFlushThreeTimes(rows, table, famStr);
 
 Review comment:
   and it looks like the implementation also waits for the flushes to be done 
before doing that check. (The call to `Admin.flush` is synchronous.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to