busbey commented on a change in pull request #1446: HBASE-23723 Ensure MOB
compaction works in optimized mode after snapshot clone
URL: https://github.com/apache/hbase/pull/1446#discussion_r405724062
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreFlusher.java
##########
@@ -280,7 +283,11 @@ protected void finalizeWriter(StoreFileWriter writer,
long cacheFlushSeqNum,
// The hfile is current up to and including cacheFlushSeqNum.
status.setStatus("Flushing " + store + ": appending metadata");
writer.appendMetadata(cacheFlushSeqNum, false);
- writer.appendMobMetadata(mobRefSet.get());
+ //writer.appendMobMetadata(ImmutableSetMultimap.builder<TableName,
String>().putAll(store.getTableName(),
+ // mobRefSet.get()).build());
Review comment:
sorry, I can't seem to retrace the context for this comment. could you take
a look at the most recent change set and see if you have a concern still?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
