busbey commented on a change in pull request #1446: HBASE-23723 Ensure MOB
compaction works in optimized mode after snapshot clone
URL: https://github.com/apache/hbase/pull/1446#discussion_r405718121
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java
##########
@@ -180,6 +180,42 @@ public void baseTestMobFileCompaction() throws
InterruptedException, IOException
LOG.info("MOB compaction " + description() + " finished OK");
}
+ @Test
+ public void testMobFileCompactionAfterSnapshotClone() throws
InterruptedException, IOException {
+ final TableName clone = TableName.valueOf(test.getMethodName() + "-clone");
+ LOG.info("MOB compaction of cloned snapshot, " + description() + "
started");
+ loadAndFlushThreeTimes(rows, table, famStr);
+ LOG.debug("Taking snapshot and cloning table {}", table);
+ admin.snapshot(test.getMethodName(), table);
+ admin.cloneSnapshot(test.getMethodName(), clone);
Review comment:
The `Admin.snpashot` and `Admin.cloneSnasphot` calls are both synchronous.
they're only supposed to return if their operations are successful. The should
throw an exception if something goes wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
