anoopsjohn commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r422633969
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CustomizedScanInfoBuilder.java
##########
@@ -80,4 +97,23 @@ public KeepDeletedCells getKeepDeletedCells() {
return keepDeletedCells != null ? keepDeletedCells :
scanInfo.getKeepDeletedCells();
}
+ @Override
+ public int getMinVersions() {
+ return minVersions != null ? minVersions : scanInfo.getMinVersions();
+ }
+
+ @Override
+ public void setMinVersions(int minVersions) {
+ this.minVersions = minVersions;
+ }
+
+ @Override
+ public Scan getScan() {
+ try {
+ return new Scan(scan);
Review comment:
+1.. That was something came to my mind too while reading the Jira
desc. :-)
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CustomizedScanInfoBuilder.java
##########
@@ -80,4 +97,23 @@ public KeepDeletedCells getKeepDeletedCells() {
return keepDeletedCells != null ? keepDeletedCells :
scanInfo.getKeepDeletedCells();
}
+ @Override
+ public int getMinVersions() {
+ return minVersions != null ? minVersions : scanInfo.getMinVersions();
+ }
+
+ @Override
+ public void setMinVersions(int minVersions) {
+ this.minVersions = minVersions;
+ }
+
+ @Override
+ public Scan getScan() {
+ try {
+ return new Scan(scan);
Review comment:
Already the scan object been cloned while setting in this class.. Every
time with get also we need to clone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
