ramkrish86 commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r428787492



##########
File path: 
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java
##########
@@ -402,6 +402,8 @@
   String DELETE_BATCH_KEY = "deleteBatch";
   String GET_SIZE_KEY = "getSize";
   String GET_KEY = "get";
+  String MEMSTORE_GET_KEY = "getsOnMemstore";
+  String FILE_GET_KEY = "getsOnFile";

Review comment:
       Some of the gets that lands on the StoreScanners does not actually get 
accounted into actual get. Probably that row does not exist. So I thought it is 
better to track both. Also the overhead is very minimal. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to