ramkrish86 commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r428789194
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1002,6 +1012,14 @@ public Void call() throws IOException {
} finally {
this.lock.writeLock().unlock();
this.archiveLock.unlock();
+ // moving it after the unlocking so
+ // that metrics closure does not affect them
+ if (this.metricsStore != null) {
+ metricsStore.close();
Review comment:
Yes. It will do the deregister.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
